[MM] Change to the common resource manager #567
Conversation
This patch updates the mm resource manager. - Origin: https://review.tizen.org/gerrit/#/c/platform/core/api/machine-learning/+/318887/ Change-Id: I108b500c796a8899e6d582346a184d9e6a8136c4 Signed-off-by: YoungHun Kim <[email protected]> Signed-off-by: Sangjung Woo <[email protected]>
again4you
requested review from
jaeyun-jung,
myungjoo,
anyj0527,
gichan-jang,
songgot and
jijoongmoon
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #567. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
| @@ -76,7 +76,7 @@ Summary: Tizen native API for NNStreamer | |||
| # 2. Tizen : ./packaging/machine-learning-api.spec | |||
| # 3. Meson : ./meson.build | |||
| # 4. Android : ./java/android/nnstreamer/src/main/jni/Android.mk | |||
| Version: 1.8.6 | |||
| Version: 1.1.0 | |||
There was a problem hiding this comment.
The rpm version is changed! why?
| } | ||
| status = ml_tizen_mm_res_allocate(p->resources, res_type); | ||
| if (status != ML_ERROR_NONE) { | ||
| _ml_loge("Faied to allocate resource."); |
| for (type = RES_TYPE_VIDEO_DECODER; type < RES_TYPE_MAX; type++) { | ||
| ret = ml_tizen_mm_res_deallocate(mm_handle, type); | ||
| if (ret != ML_ERROR_NONE) { | ||
| _ml_loge("Fail to deallocate resoure [type %d].", type); |
There was a problem hiding this comment.
resoure->resource
| @@ -23,7 +23,7 @@ if (get_option('enable-tizen')) | |||
|
|
|||
| nns_capi_deps += dependency('mm-camcorder') | |||
| if (tizenVmajor >= 5) | |||
There was a problem hiding this comment.
| if (tizenVmajor >= 5) | |
| if (tizenVmajor >= 9) |
| @@ -110,7 +110,8 @@ BuildRequires: pkgconfig(capi-privacy-privilege-manager) | |||
| %endif | |||
| BuildRequires: pkgconfig(mm-camcorder) | |||
| %if 0%{tizen_version_major} >= 5 | |||
There was a problem hiding this comment.
5 -> 9. Or make an another if phrase ?
| base = g_path_get_basename(contents); | ||
|
|
||
| if (g_strlcpy(appid, base, size) >= size) | ||
| LOGE("string truncated"); |
There was a problem hiding this comment.
Return error or change log level to warning?
| _ml_logi("app id : %s type %d", resources->rci.app_id, type); | ||
| memset(&request_resources, 0x0, sizeof(rm_category_request_s)); | ||
|
|
||
| device = &resources->devices[type]; |
There was a problem hiding this comment.
Isn't validation of device necessary?
This patch updates the mm resource manager.
Change-Id: I108b500c796a8899e6d582346a184d9e6a8136c4
Signed-off-by: YoungHun Kim [email protected]
Signed-off-by: Sangjung Woo [email protected]